App Submission - Zabbix

[DavidGarciaCat]

I created this Zabbix app for my community store, so I could add it to my Umbrel OS easily.

Given that there are other network tools and that Zabbix is one of the most useful monitoring tools available, it might be interesting to have it here, too.

Feedback is more than welcome!

[sharknoon]

Thank you @DavidGarciaCat for your App Submission! Really good work.
I have only one question in this review (see below). I will test the app and give you feedback.

[sharknoon]

Thank you so much @DavidGarciaCat for your work! Two things I have noticed:

• A .gitkeep file is missing for data/postgres
• The use of the standard container user. Can you try to add user: 1000:1000 to the containers? It could be that some containers won't start with a different user, but those who do work fine with the new user are properly sandboxed.

[DavidGarciaCat]

• A .gitkeep file is missing for data/postgres

We have the .gitkeep file in the data folder; what you are saying is that we should move it inside the data/postgres instead? Please confirm so I can add this fix.

• The use of the standard container user. Can you try to add user: 1000:1000 to the containers? It could be that some containers won't start with a different user, but those who do work fine with the new user are properly sandboxed.

OK, I will check this UID and set it ASAP

[sharknoon]

Thank you for your quick response 😀
Yes, please move it to data/postgres instead. In the current case, docker would create the postgres directory by itself, with wrong permissions. Therefore we unfortunately have to create for each empty directory a .gitkeep file.
Thanks for checking the UID / GID

[DavidGarciaCat]

@sharknoon I was checking the note for the user, and running cat /etc/passwd I can see there's no 1000 user we can use here.

However, running whoami, I can see the primary user seems to be zabbix with UID 1997:

$ whoami
zabbix

$ cat /etc/passwd
...
zabbix:x:1997:1995:Zabbix monitoring system:/var/lib/zabbix/:/sbin/nologin

This user is already set as the default user for the container when pulling the images.

Do we still need to make adjustments for the containers?

[sharknoon]

Hi @DavidGarciaCat
thank you for the update! If there is already a user other than root, this is totally fine 😀 Good catch!

[DavidGarciaCat]

@sharknoon, thanks for your confirmation

@nmfretz, I think all feedback has been implemented - are we ready to go live with this new app?

[nmfretz]

Thanks for the submission @DavidGarciaCat. I have left a review below with some items to address.

Let @sharknoon and I know if anything is confusing!

[nmfretz]

Does this port need to be exposed on the host for some reason (e.g., some external application other than zabbix needs to access it), or can we just remove this and rely on Docker DNS? We don't want to expose extra ports than are necessary.

[DavidGarciaCat]

Zabbix Server Port should be open as it is used to get comms from the installed agents in the monitored devices. This one should remain open/exposed.

[nmfretz]

Thanks 👌

[nmfretz]

Thanks again for your hard work on Zabbix @DavidGarciaCat! I have pushed some commits to finalize this submission and have added gallery assets:

Going live to the app store 🎉

[DavidGarciaCat]

Thank you, @nmfretz! It has been my pleasure to work providing a new tool that I believe might be very useful, especially for SME users.

I also appreciate your feedback and will try to remember it for other potential submissions.

[DavidGarciaCat]

Hey, @nmfretz!

As part of the getting ready process you guys ran, there was a typo in the description/setup

Please refer to this new PR to fix it #1496

Cheers!

[nmfretz]

Thanks for the eagle-eyes @DavidGarciaCat! Merged.