Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-labels to footnotes and footnote backlinks #693

Closed
wants to merge 1 commit into from

Conversation

stevenjmesser
Copy link

Related to #692, here's a pull request to make footnotes accessible to screen readers.

@gettalong
Copy link
Owner

You are using rel="footnote" (lowercase) but in some tests "Footnote" is written. So this would need to be fixed.

Furthermore, I don't want to introduce an English language default which would mix languages when the document is not written in English. Is aria-label meant to be an "internal" reference like with the role attribute? Or is this something a screen reader would actual read out loud?

If it is the latter, we would need to introduce a new option like footnote_labels that defines the text of the labels, with the default being off.

@kinoute
Copy link

kinoute commented Apr 4, 2021

any update on this?

@stevenjmesser
Copy link
Author

I need to think about how to address @gettalong's comments as I'm not a developer, @kinoute! But do you have any ideas? I think I'd need to think about multilingual support most...

psfrolov added a commit to psfrolov/kramdown that referenced this pull request Jul 5, 2021
Fixes gettalong#719. PR gettalong#693 also incorporate this fix, but has gone stale.
BryceStevenWilley pushed a commit to BryceStevenWilley/kramdown that referenced this pull request Nov 18, 2022
Fixes gettalong#719. PR gettalong#693 also incorporate this fix, but has gone stale.
@gettalong gettalong self-assigned this Mar 15, 2023
gettalong pushed a commit that referenced this pull request Mar 15, 2023
Fixes #719. PR #693 also incorporate this fix, but has gone stale.
@stevenjmesser
Copy link
Author

Closing as addressed in #773

@stevenjmesser stevenjmesser deleted the a11y-footnotes branch July 3, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants