Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache the result of Demangling #1124

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Cache the result of Demangling #1124

merged 1 commit into from
Apr 5, 2023

Commits on Apr 5, 2023

  1. Cache the result of Demangling 

    Demangling can be an expensive operation, which also happens for every frame and is not deduplicated for the same function names shared across threads.
Furthermore, we capture errors for demangling failures, to eventually be able to improve those. However we are being spammed with up to 8 of those errors a second, and they are highly duplicated too, making it difficult to actually find new cases we don’t handle yet.

So lets cache all the things, to avoid duplicated work and spamming S4S events.
    @Swatinem
    Swatinem committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    aea03cb View commit details
    Browse the repository at this point in the history