Skip to content

Commit

Permalink
Propagate relative_caller_addr Errors
Browse files Browse the repository at this point in the history
A followup to this review comment: #1124 (review)
  • Loading branch information
Swatinem committed Apr 6, 2023
1 parent cedeb19 commit 8873952
Showing 1 changed file with 9 additions and 11 deletions.
20 changes: 9 additions & 11 deletions crates/symbolicator-service/src/services/symbolication/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -265,17 +265,15 @@ fn symbolicate_frame(
signal,
index,
adjustment,
);
relative_addr.and_then(|addr| {
symbolicate_native_frame(
demangle_cache,
symcache,
lookup_result,
addr,
frame,
index,
)
})
)?;
symbolicate_native_frame(
demangle_cache,
symcache,
lookup_result,
relative_addr,
frame,
index,
)
}
Ok(CacheFileEntry::PortablePdbCache(ppdb_cache)) => {
symbolicate_dotnet_frame(ppdb_cache.get(), frame, index)
Expand Down

0 comments on commit 8873952

Please sign in to comment.