Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Introduce bounded demangling in an attempt to fix unbounded memo… #481

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Jan 4, 2022

…ry growth

An attempt to help with #477, however that is not solved yet.

Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iiuc this will still write as much as it likes into the BoundedString, only on using Display or ToString traits of the string will it not print the entire thing. That doesn't seem enough to fix the unbounded-ness of the allocation?

@Swatinem
Copy link
Member Author

this will still write as much as it likes into the BoundedString, only on using Display or ToString traits of the string will it not print the entire thing

I don’t really understand. No Display or ToString is involved here.

@flub
Copy link
Contributor

flub commented Jan 10, 2022

oh wait, i totally misread std::fmt::Write :/

@Swatinem Swatinem merged commit 50a4d2e into master Jan 10, 2022
@Swatinem Swatinem deleted the fix/bounded-demangling branch January 10, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants