Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devenv: replace volta #75554

Merged
merged 14 commits into from
Sep 11, 2024
Merged

devenv: replace volta #75554

merged 14 commits into from
Sep 11, 2024

Conversation

joshuarli
Copy link
Member

@joshuarli joshuarli commented Aug 2, 2024

volta uses a flaky (i think rate-limited) upstream for node downloads and doesn't retry downloads: volta-cli/volta#1523

also occasionally volta-shim on macos fork bombs (still not sure the root cause, issue here volta-cli/volta#1741), turns out it's quite easy with devenv to just manage a self-contained node

before
$ command -v node npm yarn                                                                         0
/Users/josh/dev/sentry/.devenv/bin/volta-home/tools/image/node/20.13.1/bin/node
/Users/josh/dev/sentry/.devenv/bin/volta-home/tools/image/node/20.13.1/bin/npm
/Users/josh/dev/sentry/.devenv/bin/volta-home/tools/image/yarn/1.22.22/bin/yarn

$ ~/dev/devenv/.tox/py312/bin/devenv sync                                                           0
ensuring sentry venv at .venv...
installing node v20.13.1...
installing yarn 1.22.22...
...

$ command -v node npm yarn                                                                    0
/Users/josh/dev/sentry/.devenv/bin/node  # these are shims to .devenv/bin/node-env/bin/node
/Users/josh/dev/sentry/.devenv/bin/npm
/Users/josh/dev/sentry/.devenv/bin/yarn

node-version-check is also inlined now into direnv to clean up our makefile a bit more

needs getsentry/devenv#132 + new release + bump devenv version before merging

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 2, 2024
@getsantry getsantry bot added the Stale label Aug 27, 2024
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #75554      +/-   ##
==========================================
+ Coverage   73.76%   78.16%   +4.39%     
==========================================
  Files        6949     6944       -5     
  Lines      308293   307941     -352     
  Branches    50465    50386      -79     
==========================================
+ Hits       227419   240708   +13289     
+ Misses      74251    60825   -13426     
+ Partials     6623     6408     -215     

@joshuarli joshuarli merged commit 008295a into master Sep 11, 2024
52 checks passed
@joshuarli joshuarli deleted the devenv-replace-volta branch September 11, 2024 20:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants