-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devenv: replace volta #75554
Merged
Merged
devenv: replace volta #75554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Automatically applied to PRs that change backend components
label
Aug 2, 2024
joshuarli
force-pushed
the
devenv-replace-volta
branch
from
August 28, 2024 17:44
74e56b8
to
18fdece
Compare
asottile-sentry
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asottile-sentry
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #75554 +/- ##
==========================================
+ Coverage 73.76% 78.16% +4.39%
==========================================
Files 6949 6944 -5
Lines 308293 307941 -352
Branches 50465 50386 -79
==========================================
+ Hits 227419 240708 +13289
+ Misses 74251 60825 -13426
+ Partials 6623 6408 -215 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
volta uses a flaky (i think rate-limited) upstream for node downloads and doesn't retry downloads: volta-cli/volta#1523
also occasionally volta-shim on macos fork bombs (still not sure the root cause, issue here volta-cli/volta#1741), turns out it's quite easy with devenv to just manage a self-contained node
node-version-check is also inlined now into direnv to clean up our makefile a bit more
needs getsentry/devenv#132 + new release + bump devenv version before merging