Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(inbound-filters) Remove unused inbound filter health-check feature #52099

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

RaduW
Copy link
Contributor

@RaduW RaduW commented Jul 3, 2023

This PR removes the health-check feature for inbound filters since it is no longer used

fixes: #51698

@RaduW RaduW requested a review from a team July 3, 2023 14:36
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #52099 (c336f1d) into master (1653ff8) will increase coverage by 2.15%.
The diff coverage is 75.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #52099      +/-   ##
==========================================
+ Coverage   77.16%   79.32%   +2.15%     
==========================================
  Files        4901     4901              
  Lines      205077   205146      +69     
  Branches    35055    35072      +17     
==========================================
+ Hits       158242   162722    +4480     
+ Misses      41937    37460    -4477     
- Partials     4898     4964      +66     
Impacted Files Coverage Δ
src/sentry/api/endpoints/project_filter_details.py 71.42% <0.00%> (-3.58%) ⬇️
src/sentry/conf/server.py 91.84% <ø> (+0.01%) ⬆️
src/sentry/features/__init__.py 100.00% <ø> (ø)
src/sentry/ingest/inbound_filters.py 77.41% <80.00%> (-0.71%) ⬇️
src/sentry/api/endpoints/project_filters.py 100.00% <100.00%> (ø)
src/sentry/relay/config/__init__.py 92.56% <100.00%> (+17.84%) ⬆️

... and 300 files with indirect coverage changes

@RaduW RaduW merged commit baf6b2a into master Jul 5, 2023
@RaduW RaduW deleted the ref/metrics/remove-health-check-feature branch July 5, 2023 07:35
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused health check feature flag
2 participants