-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(doc): Update health-check inbound filter API documentation #52008
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52008 +/- ##
========================================
Coverage 79.31% 79.32%
========================================
Files 4899 4901 +2
Lines 204912 205114 +202
Branches 35024 35064 +40
========================================
+ Hits 162519 162699 +180
- Misses 37438 37455 +17
- Partials 4955 4960 +5
|
@@ -237,6 +237,7 @@ class ProjectParams: | |||
- `legacy-browser`: Filter out known errors from legacy browsers. Older browsers often give less | |||
accurate information, and while they may report valid issues, the context to understand them is | |||
incorrect or missing. | |||
- `filtered-transaction`: Filter out transactions for healthcheck and ping endpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is filtered-transactions toggled? If it's done using the active
query param, you must add it to the active strin explanation. Also this filter appears to be set behind a feature flag so is it available to all users by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment.
It uses the active flag, will update the doc.
There is a followup PR, #52099, that completely removes the Feature, it was initially intended only for business plans but then it was opened for everybody so the feature flag is no longer used ( and will be shortly removed)
Update API documentation for inbound filters to contain the health-check filter
fixes: #49089