feat(doc): Update health-check inbound filter API documentation #52008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52008 +/- ##
========================================
Coverage 79.31% 79.32%
========================================
Files 4899 4901 +2
Lines 204912 205114 +202
Branches 35024 35064 +40
========================================
+ Hits 162519 162699 +180
- Misses 37438 37455 +17
- Partials 4955 4960 +5
|
sentaur-athena
approved these changes
Jun 30, 2023
schew2381
suggested changes
Jun 30, 2023
| @@ -237,6 +237,7 @@ class ProjectParams: | |||
| - `legacy-browser`: Filter out known errors from legacy browsers. Older browsers often give less | |||
| accurate information, and while they may report valid issues, the context to understand them is | |||
| incorrect or missing. | |||
| - `filtered-transaction`: Filter out transactions for healthcheck and ping endpoints. | |||
There was a problem hiding this comment.
How is filtered-transactions toggled? If it's done using the active query param, you must add it to the active strin explanation. Also this filter appears to be set behind a feature flag so is it available to all users by default?
There was a problem hiding this comment.
Thanks for the comment.
It uses the active flag, will update the doc.
There is a followup PR, #52099, that completely removes the Feature, it was initially intended only for business plans but then it was opened for everybody so the feature flag is no longer used ( and will be shortly removed)
schew2381
approved these changes
Jul 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update API documentation for inbound filters to contain the health-check filter
fixes: #49089