Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-crash-detection): Exception allow list #51028

Merged
merged 5 commits into from
Jun 29, 2023

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Jun 15, 2023

Define an allow list for the exception only to keep known properties not containing PII. This PR is based on #51022.

Fixes GH-50710

Add the implementation for the Cocoa SDK crash detection.
Add class event stripper, which only keeps event data relevant for
the SDK crash.
Define an allow list for the exception to only keep known properties
not containing PII.

Fixes GH-50710
@philipphofmann philipphofmann requested a review from a team June 15, 2023 10:18
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 15, 2023
@philipphofmann philipphofmann self-assigned this Jun 15, 2023
Base automatically changed from feat/sdk-crash-detection-event-stripper to master June 29, 2023 08:22
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #51028 (a09830e) into master (497c841) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #51028   +/-   ##
=======================================
  Coverage    79.05    79.05           
=======================================
  Files        4901     4901           
  Lines      205822   205824    +2     
  Branches    11048    11048           
=======================================
+ Hits       162703   162709    +6     
+ Misses      42874    42870    -4     
  Partials      245      245           
Impacted Files Coverage Δ
...rc/sentry/utils/sdk_crashes/sdk_crash_detection.py 46.15% <ø> (ø)
src/sentry/utils/sdk_crashes/event_stripper.py 94.44% <100.00%> (+0.21%) ⬆️

... and 3 files with indirect coverage changes

@philipphofmann philipphofmann merged commit 6620a40 into master Jun 29, 2023
@philipphofmann philipphofmann deleted the feat/sdk-crash-detection-exception-allowlist branch June 29, 2023 09:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK Crash Detection: Specify allowlist for exception
2 participants