Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK Crash Detection: Specify allowlist for exception #50710

Closed
Tracked by #49749
philipphofmann opened this issue Jun 12, 2023 · 0 comments · Fixed by #51028
Closed
Tracked by #49749

SDK Crash Detection: Specify allowlist for exception #50710

philipphofmann opened this issue Jun 12, 2023 · 0 comments · Fixed by #51028
Assignees
@philipphofmann
Labels
Scope: Backend Automatically applied to PRs that change backend components

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Jun 12, 2023 •
edited
Loading

We must specify an allowlist of fields for the exception to avoid collecting potential PII. Currently, the event_stripper keeps all properties:

sentry/src/sentry/utils/sdk_crashes/event_stripper.py

Line 40 in 11d91d2

"exception": Allow.ALL.with_explanation("We strip the exception data separately."),

@philipphofmann philipphofmann mentioned this issue Jun 12, 2023
Closed
@philipphofmann philipphofmann changed the title Specify allowlist for exception SDK Crash Detection: Specify allowlist for exception Jun 12, 2023
This was referenced Jun 12, 2023
Merged
Closed
Closed
@philipphofmann philipphofmann self-assigned this Jun 12, 2023
@philipphofmann philipphofmann added the Scope: Backend Automatically applied to PRs that change backend components label Jun 12, 2023
This was referenced Jun 12, 2023
Closed
Merged
philipphofmann added a commit that referenced this issue Jun 15, 2023
@philipphofmann
feat(sdk-crash-detection): Exception allow list
678d14d 
Define an allow list for the exception to only keep known properties
not containing PII.

Fixes GH-50710
@philipphofmann philipphofmann mentioned this issue Jun 15, 2023
Merged
philipphofmann added a commit that referenced this issue Jun 29, 2023
@philipphofmann
feat(sdk-crash-detection): Add event stripper (#51022)
497c841 
Add class event stripper, which only keeps event data relevant for the
SDK crash.

It's worth noting that we still need to fix two issues, which will be
handled in subsequent PRs, before the POC
(#49749) is done:
* #50710
* #50712

This is the fourth PR of splitting up the POC for SDK crash detection
(#49928) into multiple PRs and
is based on #51021.
philipphofmann added a commit that referenced this issue Jun 29, 2023
@philipphofmann
feat(sdk-crash-detection): Exception allow list (#51028)
6620a40 
Define an allow list for the exception only to keep known properties not
containing PII. This PR is based on
#51022.

Fixes GH-50710
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@philipphofmann philipphofmann

Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sdk-crash-detection): Exception allow list getsentry/sentry
1 participant
@philipphofmann