Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show UI frames, CPU and Memory for RN/iOS Mixed Profiles #59989

Closed
Tracked by #2668
krystofwoldrich opened this issue Nov 15, 2023 · 4 comments · Fixed by #71258
Closed
Tracked by #2668

Show UI frames, CPU and Memory for RN/iOS Mixed Profiles #59989

krystofwoldrich opened this issue Nov 15, 2023 · 4 comments · Fixed by #71258

Comments

@krystofwoldrich
Copy link
Member

Since getsentry/sentry-react-native#3349 RN SDK sends profiles with UI frames, CPU and Memory.

https://sentry-sdks.sentry.io/profiling/profile/sentry-react-native/4f0be51bd1534274b5b0fc1874520fd8/flamegraph/

Screenshot 2023-11-15 at 16 10 24

The current UI doesn't display the measurements.

Note not all RN profiles include the measurements.

@getsantry
Copy link
Contributor

getsantry bot commented Mar 8, 2024

Routing to @getsentry/product-owners-profiling for triage ⏲️

@DeeVine
Copy link
Member

DeeVine commented May 17, 2024

Hi, is there an estimate on when CPU and Memory usage will be available for RN?

@JonasBa
Copy link
Member

JonasBa commented May 21, 2024

@krystofwoldrich I cant access that flamegraph you shared. Mind sending me one where measurements were sent? I'm going to look enabling this, iirc it's just a matter of adding the platform to a whitelist that determines if the charts should be rendered.

@JonasBa
Copy link
Member

JonasBa commented May 21, 2024

@krystofwoldrich I cant access that flamegraph you shared. Mind sending me one where measurements were sent? I'm going to look enabling this, iirc it's just a matter of adding the platform to a whitelist that determines if the charts should be rendered.

Nevermind, I found it and I'm working on enabling this.

JonasBa added a commit that referenced this issue May 28, 2024
…are sent (#71258)

React native uses javascript as the platform value which is used both by
browser sdk which doesnt report cpu and memory measures. This means we
cant know ahead of time if we expect the measurements and simply enable
the charts (this toggles loading and the various no measurement states).

In order to not enable these charts for browser SDKs and confuse users,
we take a different approach and enable the charts on demand, once the
data has loaded. We miss out on some of the loading states, but this all
happens pretty fast as the profile loads, so I dont think it's a big
deal in terms of UX.

Fixes #59989
volokluev pushed a commit that referenced this issue May 28, 2024
…are sent (#71258)

React native uses javascript as the platform value which is used both by
browser sdk which doesnt report cpu and memory measures. This means we
cant know ahead of time if we expect the measurements and simply enable
the charts (this toggles loading and the various no measurement states).

In order to not enable these charts for browser SDKs and confuse users,
we take a different approach and enable the charts on demand, once the
data has loaded. We miss out on some of the loading states, but this all
happens pretty fast as the profile loads, so I dont think it's a big
deal in terms of UX.

Fixes #59989
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants