-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the client cert and key support to HttpTransport #3258
Add the client cert and key support to HttpTransport #3258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Before we can merge this, you also need to make sure to add the new options here, so they show up in the type hint for sentry_sdk.init
.
Also, please add tests for your change
Thanks, @szokeasaurusrex . The test case is added. The two new arguments are added to ClientConstructor too. The test case can pass locally in pytest. Not sure how thing is going on in the pipeline. Let's see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3258 +/- ##
==========================================
- Coverage 79.41% 79.41% -0.01%
==========================================
Files 132 132
Lines 14263 14265 +2
Branches 2992 2992
==========================================
+ Hits 11327 11328 +1
Misses 2091 2091
- Partials 845 846 +1
|
@szokeasaurusrex needs to approve this too because his request changes status is blocking the merge |
Enable 2-way SSL authentication support in sentry-sdk #3256
The document of self-hosted Sentry strongly recommends using a load balancer in front of Sentry. And when the load balancer enables two-way SSL authentication, this pull request makes sentry-sdk allow to pass the client cert and key file to urllib3.PoolManager.
This pull request adds two new key arguments to
sentry_sdk.init
:General Notes
Thank you for contributing to
sentry-python
!Please add tests to validate your changes, and lint your code using
tox -e linters
.Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.
For maintainers
Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.
Before running sensitive test suites, please carefully check the PR. Then, apply the
Trigger: tests using secrets
label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.