Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): Ensure sveltekit E2E test work with prereleases #8372

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Jun 20, 2023

Since @sentry/sveltekit depends on @sentry/vite-plugin, which in turn depens on @sentry/node@^7.19.0 & @sentry/tracing@^7.19.0, this fails to install in E2E tests for pre-release versions (e.g. 7.57.0-beta.0), as the prerelease does not satisfy the range ^7.19.0. So we override this to * to ensure this works as expected.

(Side note: We should maybe update @sentry/sveltekit to use the latest @sentry/vite-plugin?)

Since @sentry/sveltekit depends on @sentry/vite-plugin, which in turn depens on `@sentry/node@^7.19.0`, this fails to install in E2E tests for pre-release versions (e.g. 7.57.0-beta.0`), as the prerelease does not satisfy the range `^7.19.0`. So we override this to `*` to ensure this works as expected.
@mydea mydea self-assigned this Jun 20, 2023
@mydea mydea enabled auto-merge (squash) June 20, 2023 14:57
@mydea mydea merged commit b84c23f into develop Jun 21, 2023
@mydea mydea deleted the fn/e2e-prereleases branch June 21, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants