Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(profiling): Move profiling types to types and cache to utils #8270

Merged
merged 7 commits into from
Jun 20, 2023

Conversation

krystofwoldrich
Copy link
Member

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

I've moved some profiling code so it's possible to share it with RN.

I've added transaction to the profile as here in JS profile contains only transactions array.

Also added some profile sub-types (sample, frame, stack) so they can be used separately.

Also added yalc publish to the hub package, since it's used in RN and useful for local tests of the changes.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.17 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 66.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.71 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 58.6 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.33 KB (0%)
@sentry/browser - Webpack (minified) 69.52 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.36 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.28 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.79 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 27.03 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 49.34 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 43.08 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 68.35 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.26 KB (0%)

@JonasBa
Copy link
Member

JonasBa commented Jun 1, 2023

@krystofwoldrich changes make sense to me, this used to just live in browser profiling as it was the only place that it was used in. Will let other JS maintainers make the final call here

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good idea on extracting this stuff out!

packages/utils/src/cache.ts Outdated Show resolved Hide resolved
@AbhiPrasad
Copy link
Member

Also added yalc publish to the hub package, since it's used in RN and useful for local tests of the changes.

Can we work on removing usage of @sentry/hub from react native?

@krystofwoldrich krystofwoldrich merged commit 9d8464b into develop Jun 20, 2023
@krystofwoldrich krystofwoldrich deleted the kw-rn-profiling-share-code branch June 20, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants