Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change close/flushes to return false on failure #3823

Closed
wants to merge 1 commit into from
Closed

Change close/flushes to return false on failure #3823

wants to merge 1 commit into from

Commits on Jul 20, 2021

  1. Change close/flushes to return false on failure 

    This matches the comment, and currently rejecting a promise will cause an uncaught promise exception which doesn't get caught and the causes the application to crash. Additionally, rejecting a promise with a boolean doesn't cause a stack trace which made this hard to diagnose. If keeping the rejection is preferred, then it should instead reject with an error object, not just a boolean.
    @cnorthwood
    cnorthwood committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    dc46b1a View commit details
    Browse the repository at this point in the history