Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(feedback): Call dialog.close() in dialog close callbacks in _loadAndRenderDialog #13203

Merged
merged 3 commits into from
Aug 2, 2024
Merged

fix(feedback): Call dialog.close() in dialog close callbacks in _loadAndRenderDialog #13203

merged 3 commits into from
Aug 2, 2024

Commits on Aug 2, 2024

  1. Call dialog.close() in onFormClose and onFormSubmitted callbacks for … 

    …createForm forms
    @spalmurray-codecov
    spalmurray-codecov committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    f9a040a View commit details
    Browse the repository at this point in the history

  2. Move dialog.close() call into _loadAndRenderDialog

    @spalmurray-codecov
    spalmurray-codecov committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    841d57c View commit details
    Browse the repository at this point in the history

  3. Revert change to onFormClose for _attachTo

    @spalmurray-codecov
    spalmurray-codecov committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    7be412c View commit details
    Browse the repository at this point in the history