Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs/v7): Support Hybrid Cloud DSNs with tunnelRoute option #10958

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Mar 7, 2024

Fixes #10948

The new Hybrid Cloud DSNs are incompatible with the tunnelRoute option. This PR adds some extra matching to support the new DSNs including the region code.

It is paramount that we check for the pattern of the passed query params in the Next.js rewrite matcher to avoid any sort of SSRF.

@lforst lforst changed the title feat(nextjs): Support Hybrid Cloud DSNs with tunnelRoute option feat(nextjs/v7): Support Hybrid Cloud DSNs with tunnelRoute option Mar 7, 2024
@lforst lforst requested review from mydea, s1gr1d and oioki March 7, 2024 09:39
Copy link
Contributor

github-actions bot commented Mar 7, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.71 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.87 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.83 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 63.48 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.84 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 34.88 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.44 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.45 KB (0%)
@sentry/browser - Webpack (gzipped) 22.68 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.98 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 68.4 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 34.2 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.11 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 215.54 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 103.35 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.38 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 37.37 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 70.25 KB (0%)
@sentry/react - Webpack (gzipped) 22.71 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 89.13 KB (+0.04% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 53.31 KB (+0.05% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.28 KB (0%)

@AbhiPrasad AbhiPrasad mentioned this pull request Mar 7, 2024
Co-authored-by: Alexander Tarasov <git@oioki.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants