Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nextjs): Client code should not use Node global #10925

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix(nextjs): Client code should not use Node global #10925

merged 1 commit into from
Mar 5, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 5, 2024 •
edited
Loading

Found while working through ESM issues in #10833.

For whatever reason this passed all the integration tests until ESM was used 🤯

@timfish timfish requested a review from lforst March 5, 2024 12:28
@timfish timfish mentioned this pull request Mar 5, 2024
Closed
AbhiPrasad
AbhiPrasad approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow good catch!

@AbhiPrasad AbhiPrasad merged commit 0a0f733 into develop Mar 5, 2024
63 checks passed
@AbhiPrasad AbhiPrasad deleted the fix/nextjs-global branch March 5, 2024 13:01
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 7, 2024
Closed
AbhiPrasad pushed a commit that referenced this pull request Mar 7, 2024
@timfish @AbhiPrasad
fix(nextjs): Client code should not use Node global (#10925)
f26f68c 
Found while working through ESM issues in #10833.

For whatever reason this passes all the integration tests until ESM is
used 🤯
This was referenced Mar 12, 2024
Merged
Closed
@Lms24 Lms24 mentioned this pull request Mar 20, 2024
Merged
@Lms24 Lms24 mentioned this pull request Apr 10, 2024
Merged
@Lms24 Lms24 mentioned this pull request May 31, 2024
Merged
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Closed
This was referenced Jun 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timfish @AbhiPrasad