Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replay: Loading overlay in Angular app doesn't get removed in Replay #7703

Closed
bruno-garcia opened this issue Apr 1, 2023 · 2 comments
Closed

Replay: Loading overlay in Angular app doesn't get removed in Replay #7703

bruno-garcia opened this issue Apr 1, 2023 · 2 comments
Assignees
@mydea
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Bug

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Apr 1, 2023 •
edited by billyvg
Loading

Customer reported:

We use a "loading" overlay, overlay is showed directly in the dom and deactivated by a Angular Service on a nav event. It seem that replay doesn't take care of that so the overlay is hidding all the app, if i delete the overlay from the replay's DOM, it seem to be OK (overlay = "div#fuse-splash-screen"). It can be cool to be able to "ignore" or completely hide some divs from overlay
--

sdk.name: sentry.javascript.angular
sdk.version: 7.34.0
@bruno-garcia bruno-garcia added Package: replay Issues related to the Sentry Replay SDK Type: Bug labels Apr 1, 2023
@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@mydea mydea self-assigned this Apr 24, 2023
@mydea mydea mentioned this issue Apr 24, 2023
Merged
@billyvg
Copy link
Member

billyvg commented May 1, 2023

Closing until we get a replay/repro.

@billyvg billyvg closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2023
billyvg added a commit to getsentry/rrweb that referenced this issue May 1, 2023
@mydea @billyvg
fix: Fix CSS rules captured in Safari (#86)
7551bb1 
Safari does not escape `:` in attribute selectors correctly, so we need
to do that instead.

See rrweb-io#1208

ref getsentry/sentry-javascript#7703

---------

Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
@andreiborza andreiborza mentioned this issue Aug 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mydea mydea

Labels
Package: replay Issues related to the Sentry Replay SDK Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@billyvg @bruno-garcia @mydea