-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading spinner overlay not removed in Replay #13422
Comments
@van-duong-d3salonsolution can you inspect the content of your replay (you can just access it with your browser dev tools) and check if that seems to be correct? |
The DOM appears to be correct (see screenshot) when I inspect the replay content but the video is visually mostly blank (there's mouse movement and loading icon) |
@van-duong-d3salonsolution could you please share a link to the replay? |
Here's the link to the replay:https://d3-salon-solution.sentry.io/replays/09ebc678a03b466c9796d7cb682af3d5/?environment=staging&project=4507742914936832&query=&referrer=%2Freplays%2F&statsPeriod=14d&yAxis=count%28%29 |
Yea so for some reason For now, you could inspect the replay tree and manually set It looks like we've had this issue in the past also with the fuse splash screen: #7703 cc @billyvg |
@andreiborza here's the link to stackblitz containing the code to reproduce the issue. The one thing I changed in stackblitz's project template is index.htm which I copied from my project Please add |
Thanks! @billyvg could you take a look at this please? |
@van-duong-d3salonsolution In your application, what is the logic like to hide the splash? |
@billyvg The logic to hide the splash screen is: there is a service that fetches data from our API. The service calls Below is the method definition for Below is the method definition for FuseSplashScreenService also hides the splash screen on initialization ( the service is initialized by App component). However, since the data fetch takes some time, the splash screen is controlled via the service that fetches the data. Please let me know if you need anything. Thank you for your help |
thank you @van-duong-d3salonsolution, we'll look into that |
Any updates on this issue gentlemen? I just want to follow up, no rush intended. |
@van-duong-d3salonsolution we'll keep you informed, this is on our backlog. |
@van-duong-d3salonsolution This is because the web Animation API is not supported by our underlying replay library. As a workaround you could try either blocking the splash screen, or starting the replay integration after the splash screen disappears |
Description
The replay in this ticket was reported to be inaccurate: https://sentry.zendesk.com/agent/tickets/129896
The text was updated successfully, but these errors were encountered: