Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to co-location heuristic if sourcemap url appears remote #1871

Merged

Conversation

brettdh
Copy link
Contributor

@brettdh brettdh commented Dec 21, 2023

Applies a heuristic to guess that a sourcemap URL is a remote URL path (without scheme and domain):

  1. The string starts with /
  2. The string is not a path to an existing local file

Fixes #1870.

@brettdh brettdh force-pushed the 1870-sourcemaps-inject-missing-path branch 2 times, most recently from e1909e6 to 50a4008 Compare December 21, 2023 15:15
src/utils/sourcemaps.rs Show resolved Hide resolved
src/utils/sourcemaps.rs Outdated Show resolved Hide resolved
Copy link

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@brettdh
Copy link
Contributor Author

brettdh commented Jan 30, 2024

This is still on my todo list.

@brettdh
Copy link
Contributor Author

brettdh commented Jan 30, 2024

...but the stalebot did not remove the label. 🤔

@szokeasaurusrex
Copy link
Member

...but the stalebot did not remove the label. 🤔

I removed "Status: Stale" and added "Status: In Progress." Hopefully StaleBot leaves the PR alone going forward

@szokeasaurusrex
Copy link
Member

@brettdh is this still in progress?

@brettdh
Copy link
Contributor Author

brettdh commented Jul 17, 2024

Hmm, I thought I'd responded to these changes already, sorry. I'll try to push an update today.

@brettdh brettdh force-pushed the 1870-sourcemaps-inject-missing-path branch from 50a4008 to 93fddd5 Compare July 17, 2024 16:58
@brettdh
Copy link
Contributor Author

brettdh commented Jul 17, 2024

Responded to the comments above and resolved one. Please let me know if more is required.

Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sourcemaps inject should fall back to co-located source maps if exact path can't be found
3 participants