add ability to add viz to dashboard from query page

[alison985]

fixes #955

This PR ports the Mozilla functionality upstream.

I had to make a minor tweak to get it to run in the current redash code. I also added feedback to the user that the widget was added successfully which is not in Mozilla's branch.

Original PR with code review is here: mozilla#184

[kocsmy]

Hey @alison985 thanks for the PR, I like this idea. Can you please provide a screenshot about the new button placement + modal?

[alison985]

@kocsmy The new button on the query page is the green + button here:

And this is the modal:

[kocsmy]

Thanks for the screenshot, @alison985 — I'll propose something (hopefully) better place for this feature in a few days.

[kocsmy]

hey @alison985 — I'd recommend using this area for the button, we have most of the visualisation related things here already:

[alison985]

@kocsmy I like it a lot and have changed my code to do that instead. I do want to point out, on the off chance you didn't notice it, that on a 13" MacBook Air it takes up a good chunk of the last whitespace on the bottom of the page which points towards a future space issue.

[arikfr]

Good point about screen size, @alison985 .

How about we add icons to these buttons and in small resolutions only use the icons?

[alison985]

Works for me, in Font Awesome icons I propose:

• Edit Visualization: edit
• Add to Dashboard: plus-cicle
• Embed: code
• Download Dataset: file-download

[kocsmy]

@alison985 I think FA3 doesn't have plus-circle but icon-plus or icon-plus-sign will do. Others sounds good, too. Thank you!

[alison985]

Screenshots In responsive mode in Firefox.
Apple iPhone 6s:

MacBook Air 13" full window:

[jezdez]

@arikfr @kocsmy Codeclimate gives feedback for this pull request (and others) that implies something is wrong. Could you clarify if

a) we can safely ignore the failures here and elsewhere and

b) if it'd be an option to disable some of the more complex rules it's applying like number of arguments?

[emtwo]

In light of mozilla#482, I just wanted to bring up the issue of whether unpublished queries can be added to dashboards from the query page.

Not sure if it's been addressed yet here but it's worth being aware of.

[jezdez]

FYI I've opened #2727 to track the issue of the too strict Code Climate Analysis configuration.