Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen Code Climate Analysis Configuration #2727

Open
jezdez opened this issue Aug 8, 2018 · 1 comment
Open

Loosen Code Climate Analysis Configuration #2727

jezdez opened this issue Aug 8, 2018 · 1 comment

Comments

@jezdez
Copy link
Member

jezdez commented Aug 8, 2018

Issue Summary

We've had a few issues in pull requests where the required Code Climate check hindered quick fixes and led to multiple code iterations to pass Code Climate's maintainability checks and effectively slowed down development.

Using Code Climate is great but should not create unnecessary refactoring churn (especially when the checked code isn't covered by automated tests). Instead we should loosen the analysis configuration to reflect the current state of the code.

Steps to Reproduce

  1. Open add ability to add viz to dashboard from query page  #2656
  2. See issues relating to the number of function arguments (5 instead of allowed 4) and line numbers per function (36 instead of allowed 25).

These are just examples of course, but I would consider those settings to be indicators of hard to maintain code since it leads to splitting app logic between many different callables and spaghetti code eventually.

Note, there are 10 maintainability checks in total that we need to review for practicability in this project.

@arikfr
Copy link
Member

arikfr commented Aug 27, 2018

I never intended for CodeClimate to block pull requests merging. It's just a helper tool to find really outstanding code/style issues.

I'm totally cool with loosening these checks (at least until we migrate from Angular).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants