Added Buddhist calendar #6294
Merged
Added Buddhist calendar #6294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
commented
Jul 30, 2024
...p/src/main/java/org/odk/collect/android/widgets/datetime/pickers/BuddhistDatePickerDialog.kt
Outdated
Show resolved
Hide resolved
grzesiek2010
force-pushed
the
COLLECT-5866_1
branch
from
d28e910
to
9a95144
Compare
seadowg
requested changes
Aug 19, 2024
collect_app/src/test/java/org/odk/collect/android/support/Actions.kt
Outdated
Show resolved
Hide resolved
seadowg
approved these changes
Aug 20, 2024
|
Tested with Success Verified on device with Android 14 Verified cases:
|
|
Tested with Success Verified on device with Android 10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5866
Why is this the best possible solution? Were any other approaches considered?
This adds a new calendar in the same way we added the already existing ones in the past so there is nothing important to discuss here as the general approach is already know and tested.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This pull request introduces a new calendar without modifying any existing ones, allowing us to concentrate solely on testing the new calendar. Testing should include verifying that it functions as expected, including
month-yearandyearappearances (see the form below). To confirm that dates are converted correctly, I used this online converter: https://www.webconversiononline.com/date-conversion.aspx?from=thai&to=gregorian. You can use the same tool. It’s unnecessary to spend hours testing the conversion itself, but testing one random date from each decade (1900-2100) should be sufficient.Do we need any specific form for testing your changes? If so, please attach one.
buddhist.xlsx
Does this change require updates to documentation? If so, please file an issue here and include the link below.
getodk/docs#1840
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest