-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FormHierarchy cleanup #2730
Merged
shobhitagarwal1612
merged 19 commits into
getodk:master
from
lognaturel:form-hierarchy-cleanup
Nov 21, 2018
Merged
FormHierarchy cleanup #2730
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
cefc122
Use existing FormController variable which can't be null
lognaturel a563e99
Extract configureButtons method
lognaturel 505d4a0
Override configureButtons in view-only hiearchy
lognaturel 914ca44
Remove step to top of form or group in view-only hierarchy
lognaturel 0a61206
Move the click behavior to the base class and add comment
lognaturel 561f8ea
Extract method to handle question click
lognaturel f02a54e
Put default back button behavior in base class
lognaturel 9280d8d
Make the FormHierarchyActivity the default and remove edit
lognaturel f1937a8
Rename and comment view-only hierarchy class
lognaturel 8ec7742
Use enum for element types
lognaturel 5f58bb2
Clarify meaning of the element list
lognaturel 6573309
Clarify meaning of path field
lognaturel 2bd51d9
Clarify meaning of startIndex field
lognaturel beb151d
Explain code that scrolls hierarchy to last edited question
lognaturel 2d45af1
Explain refreshView and currentIndex
lognaturel eabe0ee
Comment HierarchyElement class
lognaturel 2c5a701
Remove unreachable null block
lognaturel 0657bbf
Refactor to prevent audits from ViewOnlyFormHierarchyActivity
cooperka 11e26de
Remove unused imports
shobhitagarwal1612 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍