-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FormHierarchy cleanup #2730
Merged
shobhitagarwal1612
merged 19 commits into
getodk:master
from
lognaturel:form-hierarchy-cleanup
Nov 21, 2018
Merged
FormHierarchy cleanup #2730
shobhitagarwal1612
merged 19 commits into
getodk:master
from
lognaturel:form-hierarchy-cleanup
Nov 21, 2018
Commits on Nov 5, 2018
-
Configuration menu - View commit details
-
Copy full SHA for cefc122 - Browse repository at this point
Copy the full SHA cefc122View commit details -
Configuration menu - View commit details
-
Copy full SHA for a563e99 - Browse repository at this point
Copy the full SHA a563e99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 505d4a0 - Browse repository at this point
Copy the full SHA 505d4a0View commit details
Commits on Nov 6, 2018
-
Remove step to top of form or group in view-only hierarchy
Introduced at https://github.com/grzesiek2010/collect/blob/2ecb17048d6ef1f6779dce5276a7c7e623d218b7/collect_app/src/main/java/org/odk/collect/android/activities/FormHierarchyActivity.java#L116 with the view-only mode. Would be useful if current index could be set when the view-only activity is opened but that doesn't seem possible since the activity is not launched from form filling.
Configuration menu - View commit details
-
Copy full SHA for 914ca44 - Browse repository at this point
Copy the full SHA 914ca44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a61206 - Browse repository at this point
Copy the full SHA 0a61206View commit details -
Configuration menu - View commit details
-
Copy full SHA for 561f8ea - Browse repository at this point
Copy the full SHA 561f8eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f02a54e - Browse repository at this point
Copy the full SHA f02a54eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9280d8d - Browse repository at this point
Copy the full SHA 9280d8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1937a8 - Browse repository at this point
Copy the full SHA f1937a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ec7742 - Browse repository at this point
Copy the full SHA 8ec7742View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f58bb2 - Browse repository at this point
Copy the full SHA 5f58bb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6573309 - Browse repository at this point
Copy the full SHA 6573309View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bd51d9 - Browse repository at this point
Copy the full SHA 2bd51d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for beb151d - Browse repository at this point
Copy the full SHA beb151dView commit details -
Explain refreshView and currentIndex
The removed comment was incorrect -- startIndex is used when the back button is pressed.
Configuration menu - View commit details
-
Copy full SHA for 2d45af1 - Browse repository at this point
Copy the full SHA 2d45af1View commit details -
Configuration menu - View commit details
-
Copy full SHA for eabe0ee - Browse repository at this point
Copy the full SHA eabe0eeView commit details -
The @nonnull annotations in HierarchyElement make this impossible. The null check was added in https://github.com/opendatakit/collect/blob/77f4f2eadc5302c9968e9cb332fb090018e9681f/src/org/odk/collect/android/activities/FormHierarchyActivity.java#L308 and I am pretty sure that it was needed only because of the .. entry added with an explicitly null index (https://github.com/opendatakit/collect/blob/77f4f2eadc5302c9968e9cb332fb090018e9681f/src/org/odk/collect/android/activities/FormHierarchyActivity.java#L186)
Configuration menu - View commit details
-
Copy full SHA for 2c5a701 - Browse repository at this point
Copy the full SHA 2c5a701View commit details
Commits on Nov 21, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0657bbf - Browse repository at this point
Copy the full SHA 0657bbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11e26de - Browse repository at this point
Copy the full SHA 11e26deView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.