Improved Map Performance for OSM basemaps #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed the USGS National Map Sat to USGS National Map Hybrid to reduce confusion and be inline with other services offering an imagery basemaps with roads.
update fork
Fixed IllegalArgumentException: Unterminated quote (getodk#1775)
Scale DPI allows for tiles to appear larger on the screen
Scale DPI allows for tiles to appear larger on the screen
Scale DPI allows for tiles to appear larger on the screen
|
👍 This is in code that @jknightco is reworking as part of https://forum.opendatakit.org/t/collect-geotrace-and-geoshape-improvements/10160 and #507 My guess is that it's small enough it's ok to merge now but I'll wait to get his feedback. |
|
Great! I was trying to figure out why the tiles looked so small, sorry I didn't look at the open issues before I submitted the pull request. |
heyjamesknight
approved these changes
Jan 13, 2018
lognaturel
approved these changes
Jan 17, 2018
|
Thank you @Archaejohn, @jknightco! |
shobhitagarwal1612
pushed a commit
to shobhitagarwal1612/collect
that referenced
this pull request
May 15, 2018
This increases the displayed size of the tiles on the screen and therefore reduces the numbers of tiles being requested at any given time to speed up the entire map display as well as increase the size of objects on the screen while maintaining the appropriate zoom level for the tile provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the displayed size of the tiles on the screen and therefore reduces the numbers of tiles being requested at any given time to speed up the entire map display as well as increase the size of objects on the screen while maintaining the appropriate zoom level for the tile provider.
What has been done to verify that this works as intended?
Tested in Android Emulator with all available OSM basemaps.
Why is this the best possible solution? Were any other approaches considered?
This is a built in approach from the MapView for OSMDroid
Are there any risks to merging this code? If so, what are they?
Doubtful
Do we need any specific form for testing your changes? If so, please attach one.