-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Map Performance for OSM basemaps #1784
Conversation
I changed the USGS National Map Sat to USGS National Map Hybrid to reduce confusion and be inline with other services offering an imagery basemaps with roads.
update fork
Fixed IllegalArgumentException: Unterminated quote (getodk#1775)
Scale DPI allows for tiles to appear larger on the screen
Scale DPI allows for tiles to appear larger on the screen
Scale DPI allows for tiles to appear larger on the screen
👍 This is in code that @jknightco is reworking as part of https://forum.opendatakit.org/t/collect-geotrace-and-geoshape-improvements/10160 and #507 My guess is that it's small enough it's ok to merge now but I'll wait to get his feedback. |
Great! I was trying to figure out why the tiles looked so small, sorry I didn't look at the open issues before I submitted the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Will make sure this makes it into the refactor as well.
Thank you @Archaejohn, @jknightco! |
This increases the displayed size of the tiles on the screen and therefore reduces the numbers of tiles being requested at any given time to speed up the entire map display as well as increase the size of objects on the screen while maintaining the appropriate zoom level for the tile provider.
This increases the displayed size of the tiles on the screen and therefore reduces the numbers of tiles being requested at any given time to speed up the entire map display as well as increase the size of objects on the screen while maintaining the appropriate zoom level for the tile provider.
What has been done to verify that this works as intended?
Tested in Android Emulator with all available OSM basemaps.
Why is this the best possible solution? Were any other approaches considered?
This is a built in approach from the MapView for OSMDroid
Are there any risks to merging this code? If so, what are they?
Doubtful
Do we need any specific form for testing your changes? If so, please attach one.