Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed IllegalArgumentException: Unterminated quote #1775

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Jan 10, 2018

Closes #1774

What has been done to verify that this works as intended?

I hardcoded a wrong string and tested if we can store an empty string if an exception curred and I didn't notice any problems.

Why is this the best possible solution? Were any other approaches considered?

I remember that there was a similar issue a few months ago... in the Hindi language probably and @shobhitagarwal1612 has fixed it using Transifex. Now it's in another language so we should handle such a case on the Collect side since it's hard to analyze all new strings from Transifex (but looks like we should analyze at least those we use as patterns for dates).

Are there any risks to merging this code? If so, what are they?

I tested using an empty string in such a case and everything was ok but that empty string is the one thing I can find dangerous.

Do we need any specific form for testing your changes? If so, please attach one.

No.

@lognaturel it's in values-mr and we probably should fix it too.
https://github.com/opendatakit/collect/blob/master/collect_app/src/main/res/values-mr/strings.xml#L177 a few wrong strings.

@lognaturel
Copy link
Member

Thanks @grzesiek2010, this is certainly much better than a crash. I fixed the mr translation in Transifex and messaged the lead translator for the language so that will be updated when we do the next release.

@lognaturel lognaturel merged commit 98624a8 into getodk:master Jan 11, 2018
Archaejohn added a commit to Archaejohn/collect that referenced this pull request Jan 11, 2018
Fixed IllegalArgumentException: Unterminated quote (getodk#1775)
shobhitagarwal1612 pushed a commit to shobhitagarwal1612/collect that referenced this pull request May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IllegalArgumentException: Unterminated quote
3 participants