Fixed IllegalArgumentException: Unterminated quote #1775
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1774
What has been done to verify that this works as intended?
I hardcoded a wrong string and tested if we can store an empty string if an exception curred and I didn't notice any problems.
Why is this the best possible solution? Were any other approaches considered?
I remember that there was a similar issue a few months ago... in the Hindi language probably and @shobhitagarwal1612 has fixed it using Transifex. Now it's in another language so we should handle such a case on the Collect side since it's hard to analyze all new strings from Transifex (but looks like we should analyze at least those we use as patterns for dates).
Are there any risks to merging this code? If so, what are they?
I tested using an empty string in such a case and everything was ok but that empty string is the one thing I can find dangerous.
Do we need any specific form for testing your changes? If so, please attach one.
No.
@lognaturel it's in values-mr and we probably should fix it too.
https://github.com/opendatakit/collect/blob/master/collect_app/src/main/res/values-mr/strings.xml#L177 a few wrong strings.