Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2: describe_snapshots() now supports the kms-key-id filter #8005

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

bblommers
Copy link
Collaborator

Fixes #7977

@bblommers bblommers added this to the 5.0.14 milestone Aug 19, 2024
@bblommers bblommers force-pushed the ec2-snapshot-filter-by-kms-key branch from 67dab96 to b66d9ea Compare August 20, 2024 08:01
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.39%. Comparing base (fc60bd1) to head (b66d9ea).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8005      +/-   ##
==========================================
+ Coverage   94.38%   94.39%   +0.01%     
==========================================
  Files        1130     1130              
  Lines       96587    96583       -4     
==========================================
+ Hits        91159    91168       +9     
+ Misses       5428     5415      -13     
Flag Coverage Δ
servertests 29.00% <0.00%> (+0.11%) ⬆️
unittests 94.36% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit e87b117 into getmoto:master Aug 20, 2024
50 checks passed
@bblommers bblommers deleted the ec2-snapshot-filter-by-kms-key branch August 20, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The filter 'kms-key-id' for DescribeSnapshots has not been implemented in Moto yet
1 participant