Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content.uuid.index option: prevent index lookup #6564

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jul 23, 2024

Changelog

Enhancement

  • content.uuid.index option to prevent index lookup. Will throw an exception if a UUID model cannot be looked up from the cache alone. This requires you to keep a full UUID cache at all times but can be helpful for very large sites where any index lookup would run into memory limits.
    • Use content.uuid.format to specify uuid-v4 as format.

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Jul 23, 2024
@distantnative distantnative added this to the 4.4.0 milestone Jul 23, 2024
@distantnative distantnative self-assigned this Jul 23, 2024
@distantnative distantnative marked this pull request as ready for review July 23, 2024 12:04
@distantnative distantnative requested a review from a team July 23, 2024 12:04
@distantnative distantnative added the needs: two-person review 🧑‍🤝‍🧑 PR must only be merged with two approvals label Jul 23, 2024
@bastianallgeier
Copy link
Member

I had a second look at it and I would suggest to merge this. Since it's only activated by option, I don't see any risk here to get this into 4.4

@distantnative distantnative merged commit fd01db0 into develop-minor Aug 12, 2024
12 checks passed
@distantnative distantnative deleted the fix/uuid-disable-index-lookup branch August 12, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: two-person review 🧑‍🤝‍🧑 PR must only be merged with two approvals type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants