Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu blur when not inside Panel #6487

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jun 13, 2024

Description

Summary of changes

The panel menu blur method would run for narrow screen widths, trying to close the Panel menu, even when using <k-panel-outside> where the menu isn't present. It now stops trying to close the menu if the menu doesn't exist anyways.

Changelog

Fixes

Ready?

  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label Jun 13, 2024
@distantnative distantnative added this to the 4.3.1 milestone Jun 13, 2024
@distantnative distantnative self-assigned this Jun 13, 2024
@distantnative distantnative linked an issue Jun 13, 2024 that may be closed by this pull request
@distantnative distantnative requested a review from a team June 13, 2024 13:41
@distantnative distantnative merged commit 3af8dfb into develop-patch Jun 13, 2024
4 checks passed
@distantnative distantnative deleted the fix/6486-menu-toggle-outside branch June 13, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console error when small screens
2 participants