Upload dialog: improve preview icon #6424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distantnative
added
the
type: enhancement ✨
distantnative
force-pushed
the
enhancement/upload-preview-icon
branch
from
d8e9611
to
06633ca
Compare
distantnative
force-pushed
the
enhancement/upload-preview-icon
branch
from
06633ca
to
34927ce
Compare
|
I've used the chance to refactor the items into their own components. It adds the massive benefit that we can properly test them all in the lab. |
|
You forgot the UploadReplaceDialog 😥😅 |
bastianallgeier
approved these changes
May 3, 2024
|
Really happy how all of this turned out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
Enhancements
For review team