Update searches.php: Fixing panel search when uuids are disabled #6395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that would break the panel search when uuids are disabled
I couldn't find an open issue about this (which surprised me quite a bit). If UUIDs are disabled, the panel search is completely broken since 4.0. This is a quick fix that I think fixes this, but this is my first time contributing to Kirby, so I'm not too sure...
Explanation of the fix:
$page->uuid()
returnsnull
when uuids are disabled. CallingtoString()
on null throws an exception. With the fix,toString()
is not called andnull
is used instead.Fixes
Ready?
For review team