Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel fields: fix direction for content lanuage #6352

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Panel fields: fix direction for content lanuage #6352

merged 2 commits into from
Mar 25, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Mar 23, 2024 •
edited by bastianallgeier
Loading

This PR …

Fixes

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label Mar 23, 2024
@distantnative distantnative added this to the 4.2.0 milestone Mar 23, 2024
@distantnative distantnative requested a review from a team March 23, 2024 13:28
@distantnative distantnative self-assigned this Mar 23, 2024
@distantnative distantnative linked an issue Mar 23, 2024 that may be closed by this pull request
[Panel] Writing direction of panel fields is based on user language not content language #6350
Closed
bastianallgeier
bastianallgeier approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a RTL language to the lab to test this and realised that a directive isn't reactive by default. We have to also use the update hook to make it work properly. Now it seems to be working great.

@bastianallgeier bastianallgeier merged commit 9202c8d into develop-minor Mar 25, 2024
4 checks passed
@bastianallgeier bastianallgeier deleted the fix/6350-panel-content-language-direction branch March 25, 2024 10:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

[Panel] Writing direction of panel fields is based on user language not content language
2 participants
@distantnative @bastianallgeier