Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix A::prepend() #6219

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix A::prepend() #6219

merged 1 commit into from
Jan 30, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 28, 2024 •
edited
Loading

This PR …

With the previous code, non-associative arrays would not be prepended.

Fixes

  • A::prepend() now behaves the same as A::append() (just opposite side) for non-associative arrays

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

  • Add changes to release notes draft in Notion

@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label Jan 28, 2024
@distantnative distantnative added this to the 4.2.0 milestone Jan 28, 2024
@distantnative distantnative self-assigned this Jan 28, 2024
@distantnative distantnative requested a review from a team January 28, 2024 14:16
bastianallgeier
bastianallgeier approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@distantnative distantnative merged commit 7cf9069 into develop-minor Jan 30, 2024
14 checks passed
@distantnative distantnative deleted the fix/a-prepend branch January 30, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier