Refactored block table with structure field #3411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbora
added
type: bug 🐛
This was
linked to
issues
Jun 8, 2021
5 tasks
bastianallgeier
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
I moved the common methods used by the structure field and the table block into mixins (
/mixins/forms/structure.js)Note: Moved changes from #3339 I made the changes according to the
developbranch in #3339. I corrected a few minor updates in this PR.Release notes
Fixes
widthprop of columns in table block previewRefactoring
Breaking changes
None
Related issues/ideas
columnsproperty ignored #3323Ready?
When merging