Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTML tags on list items text attribute #3188 #3200

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

afbora
Copy link
Member

@afbora afbora commented Mar 10, 2021

Describe the PR

I don't know if the text attribute intentionally didn't support HTML, but now it does. If it is not supposed to be supported by security or other reasons, you can close the PR.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Added in-code documentation (if needed)
  • CI passes (runs automatically when the PR is created or run composer ci locally)
    Running locally requires PHPUnit, PHP-CS-Fixer, Psalm, PHPCPD and PHPMD.

@afbora afbora added type: enhancement ✨ Suggests an enhancement; improves Kirby difficulty: easy 🤩 labels Mar 10, 2021
@afbora afbora added this to the 3.5.4 milestone Mar 10, 2021
@afbora afbora self-assigned this Mar 10, 2021
@afbora afbora linked an issue Mar 10, 2021 that may be closed by this pull request
distantnative
distantnative previously approved these changes Apr 18, 2021
@bastianallgeier bastianallgeier dismissed stale reviews from distantnative and themself via cd87b64 April 20, 2021 10:14
@bastianallgeier bastianallgeier self-requested a review April 20, 2021 10:14
@bastianallgeier bastianallgeier merged commit 5228a38 into develop Apr 27, 2021
@bastianallgeier bastianallgeier deleted the fix/3188-html-support-on-list-items-text branch April 27, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pages section: markup and entities
3 participants