-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow nested collections (#1400) #1539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't use GLOB_BRACE as it is not available on Windows :( I also think that I didn't implement collection loading in a good way. It shouldn't be necessary to scan the collections folder in order to get a single collection. It would be better if we refactor it first and then implement the feature.
Let's rather reopen this and keep working on it ;) |
@bastianallgeier Ping - I added a suggestion how to refactor the class, only loading a collection file once it is requested. |
1361565
to
b0d1152
Compare
Describe the PR
Allows collection files to be placed inside the collections folder as well as one subdirectory lower:
to be called by
$kirby->collection('folder/name')
.Related issues