Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel Translation error #3149

Closed
beebmx opened this issue Feb 11, 2021 · 1 comment · Fixed by #3150
Closed

Panel Translation error #3149

beebmx opened this issue Feb 11, 2021 · 1 comment · Fixed by #3150
Assignees
Labels
type: bug 🐛 Is a bug; fixes a bug type: regression 🚨 Is a regression between versions
Milestone

Comments

@beebmx
Copy link

beebmx commented Feb 11, 2021

Describe the bug
There is a problem in the panel with the translation (not all languages).
If you set (por example) spanish it throw an error
Undefined array key "es"

To Reproduce
Steps to reproduce the behavior:

  1. Download a plainkit project.
  2. Create config/config.php
  3. Enable languages with 'languages' => true
  4. Create a language file site/languages/es.php
<?php

return [
    'default' => true,
    'code' => 'es',
    'direction' => 'ltr',
    'locale' => 'es_MX',
    'name' => 'Español',
    'url' => '/',
    'translations' => [
        'lang' => 'Español',
    ]
];
  1. Go to /panel
  2. An empty page will show

Note: If the translations key is empty the no error will show.

Expected behavior
The panel page (installation) should be shown

Screenshots

Kirby Version
The version affected is 3.5.2 in the 3.5.1 and below worked as expected.

Console output
image

Desktop (please complete the following information):

  • OS: macOS 11.2.1
  • Browser: Chrome, Safari
  • PHP: 7.3, 7.4, 8.0

Additional context
There is no problem with the templates, this issue only affect to the panel.

@afbora afbora added the type: bug 🐛 Is a bug; fixes a bug label Feb 11, 2021
@afbora afbora added this to the 3.5.3 milestone Feb 11, 2021
@afbora afbora added type: regression 🚨 Is a regression between versions priority: high 🔥 labels Feb 11, 2021
@afbora afbora self-assigned this Feb 11, 2021
@afbora afbora linked a pull request Feb 11, 2021 that will close this issue
4 tasks
afbora added a commit that referenced this issue Feb 11, 2021
to test injecting non-exists extensions translations language
bastianallgeier added a commit that referenced this issue Feb 11, 2021
Checks the language for extensions translations #3149
@afbora
Copy link
Member

afbora commented Feb 11, 2021

@afbora afbora closed this as completed Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug type: regression 🚨 Is a regression between versions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants