Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

Bump server-side-render npm version, attempting to fix an error #520

Closed
wants to merge 2 commits into from

Conversation

kienstra
Copy link
Collaborator

@kienstra kienstra commented Mar 9, 2020

Changes

Background

2 people have reported a similar error message to WordPress/gutenberg#18419:

Uncaught TypeError: Cannot set property ServerSideRender of #<Object> which has only a getter

This might not fix it, but it's probably a good first effort

Testing instructions

(Regression testing for the <ServerSideRender> component)

  1. Create a new post, and add a BL block with several fields
  2. Ensure the <ServerSideRender> displays as expected

@kienstra
Copy link
Collaborator Author

kienstra commented Mar 9, 2020

Here's a build of this branch for testing:

block-lab.zip

Please don't run this on production.

If you test this, could you please see if this console error still occurs?

Uncaught TypeError: Cannot set property ServerSideRender of #<Object> which has only a getter

The preview in the block editor should display without a console error:

preview-bl

Maybe this will help with
an error in ServerSideRender.
@kienstra
Copy link
Collaborator Author

kienstra commented Mar 11, 2020

Here's a build of Block Lab up to the last commit:
block-lab.zip

This isn't intended for production.

@meeyamzafar
Copy link

meeyamzafar commented Apr 26, 2020

Hi @kienstra , I also have the same problem. I have updated to the version of Block Lab you have as the last commit (not intended for production) but still get the error. I am also using WP-Engine servers, and I know you have partnered with them a while ago.

@kienstra
Copy link
Collaborator Author

Hi @meeyamzafar,
Thanks for bringing that up.

Does this build help? #524 (comment)

@kienstra kienstra closed this Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants