This repository has been archived by the owner on Nov 6, 2022. It is now read-only.
Set the posts_per_page to 100 #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this was -1. This probably wouldn't get past a VIP review. Ideally, people creating more than 100 blocks in the 'Edit Block' UI would use the PHP API.
|
Request For Review Hi @lukecarbis, Sorry, I still owe you a review for #486. When you have a chance, could you please review this? It should help our case that Block Lab performs well and scales (#485). |
|
@kienstra Maybe consider adding a comment on that line to explain why it's |
|
Sure, that's a good point. |
Explain that this can't be scalable without this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help the case that Block Lab performs well, and is scalable (#485).
The
-1value probably wouldn't get past a VIP review.Ideally, people creating more than 100 blocks in the 'Edit Block' UI would use the PHP API.