This repository has been archived by the owner on Nov 6, 2022. It is now read-only.
Add a few tests, including for Loader #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing these in an integration test is probably the most useful, as they're mainly wrappers for other logic.
Also, remove an isset() check as empty() will handle that case.
To indicate that the helpers.php functions are covered, like block_rows() and block_row().
Still, I need to add a lot of tests for this class, and a few others.
This is passing it a row number, so it should not use %s.
|
Request For Review Hi @lukecarbis, Thanks, Luke! 🎉 |
kienstra
commented
Sep 19, 2019
3 tasks
|
Thanks, Luke! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loaderand some of the new repeater helper functions