-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
Also, add $instance property declarations for other classes in tests/php/blocks/.
…egration tests Later, there should be integration tests, so prepare a separate space for them.
Since the unit tests are moved to tests/php/unit, change the path of this helper.
This tests all of the fields except for the repeater. It ensures that when they are present as attributes, they work as expected in the block template.
Add this to get_special_case_fields, As it doesn't fit into the other groups of tests.
The unit tests had been excluded in phpcs.xml This should fix many issues, but there will still be more to fix.
This should be most of the remaining issues. And running phpcbf should make this easier.
@@ -1,129 +0,0 @@ | |||
<?php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is simply moved to here.
Request For Review Hi @lukecarbis, But I'd like to switch to working on some Repeater issues, like those reported on Slack. This PR should help to test PHP regressions in fixes for those. Almost all of the diff here is from the |
@kienstra This is fantastic! It would be great if at some point the integration test also tested for blank values, and default values. |
Thanks, @lukecarbis! Good point, that's now mentioned in #404. |
phpcs.xml
In a future PR