Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

Add integration and unit tests #402

Merged
merged 7 commits into from
Aug 28, 2019
Merged

Add integration and unit tests #402

merged 7 commits into from
Aug 28, 2019

Conversation

kienstra
Copy link
Collaborator

@kienstra kienstra commented Aug 26, 2019 •
edited
Loading

  • Add an integration test for all of the fields.
  • Make the unit tests phpcs-compliant, and remove the exclusion of them in phpcs.xml
  • Test all of the fields except for the repeater.
  • Ensure that when they are present as attributes, they work as expected in the block template.

In a future PR

  • Add an integration test for the repeater.
  • Add more unit tests.

@kienstra
Add tests for Loop
50a6560 
Also, add $instance property declarations for
other classes in tests/php/blocks/.
@kienstra
Move PHPUnit tests to tests/unit, to distinguish between upcoming int…
7f978dd 
…egration tests

Later, there should be integration tests,
so prepare a separate space for them.
@kienstra
Change the path to the trait Testing_Helper
cea55b3 
Since the unit tests are moved to tests/php/unit,
change the path of this helper.
@kienstra
Add an integration test for all of the fields
be58f0c 
This tests all of the fields except for the repeater.
It ensures that when they are present as attributes,
they work as expected in the block template.
@kienstra
Test the image field, which I forgot to test before
d406eca 
Add this to get_special_case_fields,
As it doesn't fit into the other groups of tests.
@kienstra
Address phpcs issues in failed Travis build
f0f5956 
The unit tests had been excluded in phpcs.xml
This should fix many issues, but there will still be more to fix.
@kienstra
Address more phpcs issues, add a wrapper script for phpcbf
8cc9205 
This should be most of the remaining issues.
And running phpcbf should make this easier.
kienstra
kienstra commented Aug 26, 2019
View reviewed changes
tests/php/test-helpers.php
@@ -1,129 +0,0 @@
<?php
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simply moved to here.

@kienstra kienstra changed the title [WIP] Add integration and unit tests Add integration and unit tests Aug 26, 2019
@kienstra
Copy link
Collaborator Author

kienstra commented Aug 27, 2019 •
edited
Loading

Request For Review

Hi @lukecarbis,
Could you please review this? Ideally it would have an integration test for the repeater, and more unit tests.

But I'd like to switch to working on some Repeater issues, like those reported on Slack.

This PR should help to test PHP regressions in fixes for those.

Almost all of the diff here is from the tests/ directory and config files like phpunit.xml.dist.

kienstra
kienstra commented Aug 28, 2019
View reviewed changes
composer.json Show resolved Hide resolved
@lukecarbis
Copy link
Member

@kienstra This is fantastic! It would be great if at some point the integration test also tested for blank values, and default values.

@kienstra kienstra mentioned this pull request Aug 28, 2019
Open
3 tasks
@kienstra
Copy link
Collaborator Author

kienstra commented Aug 28, 2019 •
edited
Loading

@kienstra This is fantastic! It would be great if at some point the integration test also tested for blank values, and default values.

Thanks, @lukecarbis! Good point, that's now mentioned in #404.

@kienstra kienstra merged commit a93d9a7 into develop Aug 28, 2019
@kienstra kienstra deleted the add/unit-tests-repeater branch August 28, 2019 03:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lukecarbis lukecarbis lukecarbis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kienstra @lukecarbis