This repository has been archived by the owner on Nov 6, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kienstra
suggested changes
May 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
Hi @lukecarbis,
This looks really good. The DotTip is a good UX.
Thanks for your great description here.
There are a few minor points here, but feel free to merge once you're satisfied.
kienstra
approved these changes
May 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Hi @lukecarbis,
Thanks for your responses and updates. I think this is ready to merge when you'd like.
Thank you so much Ryan! |
Thank you, this is an important feature. |
lukecarbis
added a commit
to lukecarbis/block-lab
that referenced
this pull request
Aug 18, 2019
…-css-class-2 Additional CSS Class Support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple fix, but comes with our first "dot tip".
Testing the Advanced CSS Class
Include the following in your template:
Testing the DotTip
To re-enable tips you've got to clear your browser cookies, or even easier, type the following into your console:
This time clear the default tips by pressing "See next tip" > "See next tip" > "See next tip" > "Got it".
Add a block. It's got to be a block that you have authored – we don't show the tip on blocks that you haven't authored, so that it doesn't show up for non-block-lab blocks, and it doesn't show for editors / clients who are using your blocks.
Click the block to show the edit interface, then in the sidebar, open the Advanced pane. You should see something like this:
Fixes #253.
Docs needed (@RobStino?)