OGCSources enhanced temporal support #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
changed the title
pomadchin
force-pushed
the
feature/enchanced-temporal-support
branch
from
2a3bec4
to
c5015a3
Compare
pomadchin
force-pushed
the
feature/enchanced-temporal-support
branch
from
c5015a3
to
c209c7a
Compare
pomadchin
force-pushed
the
feature/enchanced-temporal-support
branch
from
fe5de1f
to
10a5205
Compare
pomadchin
force-pushed
the
feature/enchanced-temporal-support
branch
from
10a5205
to
efc0f41
Compare
pomadchin
changed the title
jisantuc
reviewed
Mar 31, 2021
|
Ugh ignore that comment it was supposed to be on a line but I presed the wrong buttons |
pomadchin
commented
Mar 31, 2021
jisantuc
reviewed
Mar 31, 2021
ogc-example/src/main/scala/geotrellis/server/ogc/conf/OgcSourceConf.scala
Outdated
Show resolved
Hide resolved
|
@jisantuc this PR introduces two new configuration options: To test it you'd need to run gt server and to add these params to any of the (temporal) layers to see how it behaves. But I can show you this demo later / I'll definitely show it on the meeting later next week. :D |
|
Can you demo to me tomorrow afternoon? Things on GitHub I need to remember to look at later stress me out |
pomadchin
force-pushed
the
feature/enchanced-temporal-support
branch
2 times, most recently
from
9c83994
to
58b7fb7
Compare
… ignore-time. Fix a incorrect OgcTime Duration computaions and parsing.
pomadchin
force-pushed
the
feature/enchanced-temporal-support
branch
from
58b7fb7
to
73f29f0
Compare
pomadchin
force-pushed
the
feature/enchanced-temporal-support
branch
3 times, most recently
from
73ba796
to
65cddbd
Compare
pomadchin
force-pushed
the
feature/enchanced-temporal-support
branch
from
65cddbd
to
e741f46
Compare
pomadchin
commented
Apr 1, 2021
| @@ -24,7 +24,7 @@ import java.time.ZonedDateTime | |||
| import scala.util.Try | |||
|
|
|||
| sealed trait OgcTimeDefault { | |||
| lazy val name: String = getClass.getName.split("\\.").last.toLowerCase | |||
| lazy val name: String = getClass.getName.split("\\$").last.toLowerCase | |||
There was a problem hiding this comment.
case objects inside the object :/
jisantuc
approved these changes
Apr 1, 2021
pomadchin
force-pushed
the
feature/enchanced-temporal-support
branch
from
682b11a
to
4481d99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds configuration option to fetch data from the CollectionSummary (that is the default behavior now)
Demo
WCS Temporal Intervals support:
WMS Temporal Intervals support:
Checklist
Closes #347
Closes #325
Closes #324