[compat]: Fixed test for pandas>2 #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas 2.0 changed a behavior w.r.t. groupby and non-numeric columns. This test doesn't need to drop the columns anymore. xref geopandas/geopandas#1999
|
The failures in https://github.com/geopandas/dask-geopandas/actions/runs/4778643792/jobs/8495193757?pr=251 are fixed by #242 (confirmed by cherry picking and running locally) Several of the other tests failed because of a pin on dask, but not pandas. Older versions of dask are not compatible with pandas>=2.0. I've pinned pandas in the |
|
@jorisvandenbossche I'd recommend merging #242 first, which should be good to go, and then I'll update this to confirm that CI is passing. |
martinfleis
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas 2.0 changed a behavior w.r.t. groupby and non-numeric columns. This test doesn't need to drop the columns anymore. xref geopandas/geopandas#1999