Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coupled resources extraction #95

Merged
merged 2 commits into from
Dec 3, 2018

Conversation

tusbar
Copy link
Contributor

@tusbar tusbar commented Dec 3, 2018

No description provided.

@tusbar tusbar added the enhancement New feature or request label Dec 3, 2018
@tusbar tusbar added this to the 2.0.2 milestone Dec 3, 2018
@tusbar tusbar self-assigned this Dec 3, 2018
@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #95 into master will increase coverage by 4.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage    9.25%   13.42%   +4.16%     
==========================================
  Files          97       97              
  Lines        2183     2183              
==========================================
+ Hits          202      293      +91     
+ Misses       1981     1890      -91
Impacted Files Coverage Δ
lib/metadata/iso/services.js 100% <100%> (+26.92%) ⬆️
lib/metadata/common/links.js 11.11% <0%> (+11.11%) ⬆️
lib/metadata/common/util.js 86.66% <0%> (+13.33%) ⬆️
lib/metadata/iso/thumbnails.js 37.5% <0%> (+37.5%) ⬆️
lib/metadata/iso/keywords.js 100% <0%> (+57.14%) ⬆️
lib/metadata/common/contacts.js 57.14% <0%> (+57.14%) ⬆️
lib/metadata/iso/categories.js 60% <0%> (+60%) ⬆️
lib/metadata/iso/statuses.js 60% <0%> (+60%) ⬆️
lib/metadata/iso/update-frequencies.js 60% <0%> (+60%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b2778...f706d30. Read the comment docs.

@tusbar tusbar force-pushed the tusbar/fix-service-coupled-resources branch from 48d6d9f to f706d30 Compare December 3, 2018 12:50
@tusbar tusbar added bug Something isn't working and removed enhancement New feature or request labels Dec 3, 2018
@tusbar tusbar merged commit e1b9b3a into master Dec 3, 2018
@tusbar tusbar deleted the tusbar/fix-service-coupled-resources branch December 3, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant