Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superagent and add got user-agent #3

Merged
merged 5 commits into from
Oct 30, 2018
Merged

Conversation

tusbar
Copy link
Contributor

@tusbar tusbar commented Oct 8, 2018

Rewrite all udata related API calls to use got.

Do not merge until sindresorhus/got#622 is released (or don’t forget to update to a version of got that includes that patch before we release this).

This also creates custom got instances that set the User-Agent headers.

There are 2 clients: lib/got.js and plugins/publish-to-udata/got.js with different user agents.

Close #19

@tusbar tusbar added the cleanup label Oct 8, 2018
@tusbar tusbar added this to the 2.0.0 milestone Oct 8, 2018
@tusbar tusbar self-assigned this Oct 8, 2018
@tusbar tusbar requested a review from jdesboeufs October 8, 2018 15:56
@tusbar tusbar force-pushed the tusbar/remove-superagent branch 2 times, most recently from 2352095 to 1ff05ff Compare October 8, 2018 16:10
@codecov-io
Copy link

codecov-io commented Oct 8, 2018

Codecov Report

Merging #3 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #3      +/-   ##
=========================================
+ Coverage    6.05%   6.07%   +0.01%     
=========================================
  Files          96      98       +2     
  Lines        2164    2157       -7     
=========================================
  Hits          131     131              
+ Misses       2033    2026       -7
Impacted Files Coverage Δ
plugins/publish-to-udata/app.js 0% <0%> (ø) ⬆️
plugins/publish-to-udata/geogw.js 0% <0%> (ø) ⬆️
lib/services/link-proxy.js 0% <0%> (ø) ⬆️
lib/got.js 0% <0%> (ø)
lib/api/routes/links.js 0% <0%> (ø) ⬆️
lib/api/middlewares/thumbnail-proxy.js 0% <0%> (ø) ⬆️
plugins/publish-to-udata/got.js 0% <0%> (ø)
plugins/publish-to-udata/udata.js 0% <0%> (ø) ⬆️
plugins/publish-to-udata/udata-proxy.js 0% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d09e1...75b22fe. Read the comment docs.

@tusbar tusbar force-pushed the tusbar/remove-superagent branch 6 times, most recently from 466bf26 to a51c5db Compare October 10, 2018 09:02
@tusbar tusbar changed the title Remove superagent Remove superagent and add got user-agent Oct 10, 2018
@tusbar tusbar force-pushed the tusbar/remove-superagent branch 3 times, most recently from d4ff711 to 30f2391 Compare October 12, 2018 10:43
@tusbar tusbar merged commit 09f3e8e into master Oct 30, 2018
@tusbar tusbar deleted the tusbar/remove-superagent branch October 30, 2018 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants