Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publication api routes #117

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Conversation

tusbar
Copy link
Contributor

@tusbar tusbar commented Dec 18, 2018

Fix 404 when published record doesn’t exist anymore.

Also get rid of publicationTarget and hardcode dgv for now.

@tusbar tusbar added the bug Something isn't working label Dec 18, 2018
@tusbar tusbar added this to the 2.0.10 milestone Dec 18, 2018
@tusbar tusbar self-assigned this Dec 18, 2018
@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #117 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   13.16%   13.19%   +0.02%     
==========================================
  Files          98       98              
  Lines        2211     2206       -5     
==========================================
  Hits          291      291              
+ Misses       1920     1915       -5
Impacted Files Coverage Δ
lib/api/index.js 0% <0%> (ø) ⬆️
lib/api/routes/publications.js 0% <0%> (ø) ⬆️
lib/api/controllers/publications.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a344afb...c6fce04. Read the comment docs.

@tusbar tusbar merged commit c003ed6 into master Dec 18, 2018
@tusbar tusbar deleted the tusbar/fix-publication-api-routes branch December 18, 2018 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant