-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few improvements when integrating with DavMail #105
base: master
Are you sure you want to change the base?
Conversation
The issue with PROPFIND is likely fixed with #92. |
You can achieve proxy support by setting environment variables: http://docs.python-requests.org/en/latest/user/advanced/?highlight=proxy#proxies But i am not sure why you'd need proxy support for DavMail. I ran it locally and just had to point the client against a local URL. |
The proxy support was helpful when trying to find out what was going wrong, going through an intercepting proxy like mitmproxy, but I believe it is useful nevertheless, which is why I included it here. By issue #92, do you mean pycarddav being replaced by vdirsyncer? At the moment, I also use pycarddav as a library, is there a way to do that with vdirsyncer? |
Not really. Vdirsyncer is just the synchronization part. It stores contacts e.g. in a directory of
You can use vdirsyncer as a library, but as it's not an exact replacement, you'll have to see if the particular feature implementation you want to use is actually within its scope. I suppose you want to take a look at the |
Hi, sorry for not getting back to you on this sooner. First let me thank you for this pull request: thanks! Second, it does not currently work for me, I get this error:
If you fix this, I'll merge this PR. |
First commit allows using proxies natively.
Second actually sends a valid request when PROPFINDing the addressbook data.